[17.0][MIG] account_check_date: Migration to 17.0#888
Open
lperez-solvos wants to merge 8 commits intoOCA:17.0from
Open
[17.0][MIG] account_check_date: Migration to 17.0#888lperez-solvos wants to merge 8 commits intoOCA:17.0from
lperez-solvos wants to merge 8 commits intoOCA:17.0from
Conversation
lperez-solvos
force-pushed
the
17.0-mig-account_check_date
branch
from
9e5f2a8 to
9161f36
Compare
DantePereyra
suggested changes
Oct 7, 2025
account_check_date/__manifest__.py
Outdated
|
|
||
| { | ||
| "name": "Account Check Date", | ||
| "version": "17.0.0.1.0", |
There was a problem hiding this comment.
Suggested change
| "version": "17.0.0.1.0", | |
| "version": "17.0.1.0.0", |
Small detail
| check_date = fields.Date( | ||
| default=fields.Date.context_today, | ||
| required=True, | ||
| readonly=True, |
There was a problem hiding this comment.
Could be readonly be on account_payment_views.xml?
- If a field is marked as readonly=True on the model, it won't be possible to import it through the Odoo import tool, so avoid it as possible and define the readonly attribute on the views instead. See more here
There was a problem hiding this comment.
Yes, this is actually unneeded. In original code states and readonly combined at field definition actually meant this:
- By default, field is readonly.
- But, for one state (
draft), is not.
So removing states at python definition should be done along with readonly deletion. And readonly management 100% moved to view (that is currently done)
lperez-solvos
force-pushed
the
17.0-mig-account_check_date
branch
from
9161f36 to
833fe5d
Compare
DantePereyra
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standard Migration to 17.0.
Changes: